Fix PlaySlider precision and add values property#180
Merged
Conversation
Fix floating-point rounding artifacts in PlaySlider by rounding snapped values to the step's decimal precision in both JS and Python. Add a `values` property that returns all discrete values in the range. Bump version to 0.2.40 and update demo pin. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.30000000000000004with step=0.1) by rounding snapped values to the step's decimal precision in both JS frontend and Python backend.valuesproperty that returns all discrete values in the range, so users can pre-cache downstream computations before hitting play.Test plan
uv run python -c "from wigglystuff import PlaySlider; s = PlaySlider(min_value=0, max_value=1, step=0.1); print(s.values)"returns clean[0.0, 0.1, ..., 1.0]demos/play_slider.pyin marimo, set step=0.1, confirm no rounding artifacts in label or Python value🤖 Generated with Claude Code